i3wangyi commented on a change in pull request #639: Refine the WAGED
rebalancer to minimize the partial rebalance workload.
URL: https://github.com/apache/helix/pull/639#discussion_r354627219
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -443,12 +469,19 @@ private void
refreshBaseline(ResourceControllerDataProvider clusterData,
getBaselineAssignment(_assignmentMetadataStore, currentStateOutput,
resourceMap.keySet());
// Read the best possible assignment from metadata store
- Map<String, ResourceAssignment> currentBestPossibleAssignment =
getBestPossibleAssignment(
- _assignmentMetadataStore, currentStateOutput, resourceMap.keySet());
-
- // Compute the new assignment
- Map<String, ResourceAssignment> newAssignment =
calculateAssignment(clusterData, clusterChanges,
- resourceMap, activeNodes, currentBaseline,
currentBestPossibleAssignment);
+ Map<String, ResourceAssignment> currentBestPossibleAssignment =
+ getBestPossibleAssignment(_assignmentMetadataStore, currentStateOutput,
Review comment:
again, isn't it just duplicate since the below private method knows about
the private field `_assignmentMetadataStore`, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
