pkuwm commented on a change in pull request #644: Customize IZkStateListener to
add handleNewSession(sessionId)
URL: https://github.com/apache/helix/pull/644#discussion_r354601587
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkEventThread.java
##########
@@ -38,16 +38,23 @@
public static abstract class ZkEvent {
- private String _description;
+ private final String _description;
+ private final String _sessionId;
public ZkEvent(String description) {
Review comment:
I don't think we can deprecate this constructor, as this is still in use for
data change/child change/SessionEstablishmentError events. I think we can
deprecate this constructor only if we also modify data change/child
change/SessionEstablishmentError events to use the session aware
`ZkEvent(description, session)`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
