narendly commented on a change in pull request #644: Customize IZkStateListener
to add handleNewSession(sessionId)
URL: https://github.com/apache/helix/pull/644#discussion_r354693188
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/client/HelixZkClient.java
##########
@@ -35,8 +36,48 @@
void unsubscribeDataChanges(String path, IZkDataListener listener);
+ /*
+ * This is for backwards compatibility.
+ *
+ * TODO: remove below default implementation when getting rid of I0Itec in
the new zk client.
+ */
+ default void subscribeStateChanges(
+ final org.apache.helix.manager.zk.zookeeper.IZkStateListener listener) {
Review comment:
Nit: is there a way to switch the way express IZkStateListeners?
So that listener's type here would be just `IZkStateListener` and the method
signature in 69 would be the IOItec's `IZkStateListener`.
I am suggesting this because HelixZkClient is in the manager module.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
