jiajunwang commented on a change in pull request #639: Refine the WAGED
rebalancer to minimize the partial rebalance workload.
URL: https://github.com/apache/helix/pull/639#discussion_r355083552
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/WagedRebalancer.java
##########
@@ -465,62 +498,38 @@ private void
refreshBaseline(ResourceControllerDataProvider clusterData,
if (_assignmentMetadataStore != null) {
try {
_writeLatency.startMeasuringLatency();
- // TODO Test to confirm if persisting the final assignment (with final
partition states)
- // would be a better option.
_assignmentMetadataStore.persistBestPossibleAssignment(newAssignment);
_writeLatency.endMeasuringLatency();
} catch (Exception ex) {
throw new HelixRebalanceException("Failed to persist the new best
possible assignment.",
HelixRebalanceException.Type.INVALID_REBALANCER_STATUS, ex);
}
} else {
- LOG.debug("Assignment Metadata Store is empty. Skip persist the baseline
assignment.");
+ LOG.debug("Assignment Metadata Store is null. Skip persisting the
baseline assignment.");
Review comment:
I think I answered this question in your first review : )
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
