narendly commented on a change in pull request #644: Add new interface
IZkStateListener to provide session aware handleNewSession for ZkHelixManager
URL: https://github.com/apache/helix/pull/644#discussion_r355287866
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZkCallbackCache.java
##########
@@ -220,7 +220,7 @@ public void handleStateChanged(KeeperState state) throws
Exception {
}
@Override
- public void handleNewSession() throws Exception {
+ public void handleNewSession(final String sessionId) throws Exception {
Review comment:
I know we already reached an agreement not to keep the old method signature,
but let's double check - users shouldn't be extending this class, right? Should
we still try to make this backward-compatible in case users are using this
public method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
