pkuwm commented on a change in pull request #647: Add java API to create
cluster with CloudConfig
URL: https://github.com/apache/helix/pull/647#discussion_r356375225
##########
File path: helix-core/src/main/java/org/apache/helix/tools/ClusterSetup.java
##########
@@ -176,6 +179,30 @@ public void close() {
}
}
+ public void addCluster(String clusterName, boolean overwritePrevious,
boolean isCloudEnabled)
Review comment:
Just my 2 cents: to me, passing a boolean param to a method to determine the
behavior is kind of code smell.
See https://martinfowler.com/bliki/FlagArgument.html
Can we have a better design for this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
