jiajunwang opened a new pull request #651: Improve the algorithm so it prioritizes the assignment to the idle nodes when the constraint evaluation results are the same URL: https://github.com/apache/helix/pull/651 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: #650 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: This is to get rid of the randomness when the constraint-based evaluation result is a tie. Usually, when the algorithm picks up the nodes with the same score randomly, more partition movements will be triggered. A better strategy is filling the idle nodes (AKA the newly added nodes first). So those assignments won't cause a chain reaction that the other partition placements have to be altered. ### Tests - [ ] The following tests are written for this issue: We are using the same correctness based tests to cover this logic change. For the performance-related tests, we will do that in the long run test later. The report will be provided by then. - [ ] The following is the result of the "mvn test" command on the appropriate module: Running ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation in the following wiki page: TBD, we will conclude the detail design soon after the algorithm has been tested and finalized. ### Code Quality - [ ] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
