i3wangyi commented on a change in pull request #651: Improve the algorithm so
it prioritizes the assignment to the idle nodes when the constraint evaluation
results are the same
URL: https://github.com/apache/helix/pull/651#discussion_r356817556
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterContext.java
##########
@@ -104,6 +106,15 @@
_estimatedMaxTopStateCount =
estimateAvgReplicaCount(totalTopStateReplicas, instanceCount);
_baselineAssignment = baselineAssignment;
_bestPossibleAssignment = bestPossibleAssignment;
+
+ _busyInstances = _bestPossibleAssignment.values().stream().flatMap(
Review comment:
Is it because of yesterday's my question: if the cluster's present (current
mapping) is a determined intermediate result from the past's (init mapping)
calculation, the future of the cluster (final mapping) needs to be determined
by the "past"'s calculation **best possible mapping** rather than current
mapping? It sounds complex but I feel it's one of the trickiest things to
understand and relate in code in the event-driven stateful system.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
