alirezazamani commented on a change in pull request #647: Add java API to
create cluster with CloudConfig
URL: https://github.com/apache/helix/pull/647#discussion_r356844837
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixAdmin.java
##########
@@ -1025,6 +1026,23 @@ public void dropResource(String clusterName, String
resourceName) {
accessor.removeProperty(keyBuilder.resourceConfig(resourceName));
}
+ @Override
+ public void addCloudConfig(String clusterName, CloudConfig cloudConfig) {
+ logger.info("Add CloudConfig to cluster {}.", clusterName);
Review comment:
Done. Some of the fields ave been logged. Other fields such as ProcessorName
and Sources have not been added since they might be null and logging them can
cause an exception.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
