jiajunwang commented on a change in pull request #651: Improve the algorithm so
it prioritizes the assignment to the idle nodes when the constraint evaluation
results are the same
URL: https://github.com/apache/helix/pull/651#discussion_r356863398
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterContext.java
##########
@@ -104,6 +106,15 @@
_estimatedMaxTopStateCount =
estimateAvgReplicaCount(totalTopStateReplicas, instanceCount);
_baselineAssignment = baselineAssignment;
_bestPossibleAssignment = bestPossibleAssignment;
+
+ _busyInstances = _bestPossibleAssignment.values().stream().flatMap(
+ resourceAssignment ->
resourceAssignment.getRecord().getMapFields().values().stream()
Review comment:
I agree. Just this seems to be a too large change for this PR. Let me try
the best to make it clearer with less code change. I have moved the calculation
to the algorithm implementation for now. Later, as you mentioned if we have
more requirements, we can split it out to a class.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
