pkuwm commented on issue #644: Add new interface IZkStateListener to provide session aware handleNewSession for ZkHelixManager URL: https://github.com/apache/helix/pull/644#issuecomment-564801081 Tests passed. [INFO] Tests run: 890, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3,384.407 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 890, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 56:29 min [INFO] Finished at: 2019-12-11T16:44:46-08:00 This PR is ready to be merged, approved by @jiajunwang @narendly Commit message: ``` I0Itec IZkStateListener doesn't have an API handleNewSession(sessionId) to handle session aware operation, which is needed to fix session race condition for creating ephemeral node in ZkClient. So this new IZkStateListener interface is introduced to provide session aware handleNewSession method for ZkHelixManager. Changelist: - Introduce new IZkStateListener to helix. The new IZkStateListener adds new method handleNewSession(String sessionId), and removes the old method handleNewSession(). - Add default implementations I0ItecIZkStateListenerHelixImpl in IZkStateListener and IZkStateListenerI0ItecImpl in ZkClient for backward compatibility. - Add session id to ZkEvent as a private field to help debug ZkEvent. - Add unit tests to test subscribe/unsubscribe state changes. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
