zhangmeng916 opened a new pull request #653: add Helix cloud properties factory and class URL: https://github.com/apache/helix/pull/653 ### Issues - [X] My PR addresses the following Helix issues and references them in the PR description: (#[652](https://github.com/apache/helix/issues/652)) ### Description - [X] Here are some details about my PR, including screenshots of any UI changes: When the participant of Helix is running inside a cloud environment and would like to auto register to its cluster, there are a couple of properties needed, e.g. which function to use to fetch/parse the cloud instance information, what is the source for retrieving cloud instance information, as well as some user defined properties, e.g. http timeout, max retries, etc. We nee to have a globally available Helix Cloud properties defined so that different classes may use it. This PR creates a singleton Helix cloud properties factory, and a Helix cloud properties class. In Helix cloud properties, properties are read from different sources and combined to store in the memory. The local properties will be used later by participants and cloud instance information processor. ### Tests - [X] The following is the result of the "mvn test" command on the appropriate module: [ERROR] Tests run: 895, Failures: 3, Errors: 0, Skipped: 0, Time elapsed: 3,773.486 s <<< FAILURE! - in TestSuite [ERROR] testWorkflowFailureJobThreshold(org.apache.helix.integration.task.TestJobFailureDependence) Time elapsed: 300.015 s <<< FAILURE! org.testng.internal.thread.ThreadTimeoutException: Method org.testng.internal.TestNGMethod.testWorkflowFailureJobThreshold() didn't finish within the time-out 300000 [ERROR] testWorkflowJobFail(org.apache.helix.integration.task.TestWorkflowTermination) Time elapsed: 10.043 s <<< FAILURE! org.apache.helix.HelixException: Workflow "testWorkflowJobFail" context is empty or not in states: "[FAILED]", current state: "IN_PROGRESS" at org.apache.helix.integration.task.TestWorkflowTermination.testWorkflowJobFail(TestWorkflowTermination.java:223) [ERROR] testClusterStatusMonitorLifecycle(org.apache.helix.monitoring.TestClusterStatusMonitorLifecycle) Time elapsed: 6.413 s <<< FAILURE! java.lang.AssertionError: expected:<true> but was:<false> at org.apache.helix.monitoring.TestClusterStatusMonitorLifecycle.testClusterStatusMonitorLifecycle(TestClusterStatusMonitorLifecycle.java:290) [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestJobFailureDependence.testWorkflowFailureJobThreshold » ThreadTimeout Metho... [ERROR] TestWorkflowTermination.testWorkflowJobFail:223 » Helix Workflow "testWorkflow... [ERROR] TestClusterStatusMonitorLifecycle.testClusterStatusMonitorLifecycle:290 expected:<true> but was:<false> [INFO] [ERROR] Tests run: 895, Failures: 3, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] Reactor Summary for Apache Helix 0.9.2-SNAPSHOT: [INFO] [INFO] Apache Helix ....................................... SUCCESS [ 0.295 s] [INFO] Apache Helix :: Core ............................... FAILURE [ 01:02 h] [INFO] Apache Helix :: Admin Webapp ....................... SKIPPED [INFO] Apache Helix :: Restful Interface .................. SKIPPED [INFO] Apache Helix :: HelixAgent ......................... SKIPPED [INFO] Apache Helix :: Recipes ............................ SKIPPED [INFO] Apache Helix :: Recipes :: Rabbitmq Consumer Group . SKIPPED [INFO] Apache Helix :: Recipes :: Rsync Replicated File Store SKIPPED [INFO] Apache Helix :: Recipes :: distributed lock manager SKIPPED [INFO] Apache Helix :: Recipes :: distributed task execution SKIPPED [INFO] Apache Helix :: Recipes :: service discovery ....... SKIPPED [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 01:02 h [INFO] Finished at: 2019-12-11T20:27:48-08:00 [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.0.0-M3:test (default-test) on project helix-core: There are test failures. [ERROR] [ERROR] Please refer to /Users/mnzhang/helix/helix-core/target/surefire-reports for the individual test results. [ERROR] Please refer to dump files (if any exist) [date].dump, [date]-jvmRun[N].dump and [date].dumpstream. [ERROR] -> [Help 1] [ERROR] [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug logging. [ERROR] [ERROR] For more information about the errors and possible solutions, please read the following articles: [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException [ERROR] [ERROR] After correcting the problems, you can resume the build with the command [ERROR] mvn <args> -rf :helix-core ### Commits - [X] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [X] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
