i3wangyi commented on a change in pull request #655: Add an option for using
dedicated ZkConnection in ZkBaseDataAccessor
URL: https://github.com/apache/helix/pull/655#discussion_r357354291
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZkBaseDataAccessor.java
##########
@@ -56,6 +57,24 @@
import org.slf4j.LoggerFactory;
public class ZkBaseDataAccessor<T> implements BaseDataAccessor<T> {
+
+ // Designates which mode ZkBaseDataAccessor should be created in. If not
specified, it will be
+ // created on SHARED mode.
+ enum ZkClientType {
Review comment:
public enum? Otherwise, how client get access to the enum in the
constructor?
I think for the ease of client, the builder pattern is more straightforward
to read. Otherwise, one needs to read all the comments of enums and NOTE
sessions of each constructor to figure out the right one.
`ZkBaseDataAccessor.Builder(zkAddress).setSerializer(XXX).buildDedicate()`
`ZkBaseDataAccessor.Builder(zkAddress).setSerializer(XXX).buildShared()`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
