alirezazamani opened a new pull request #659: Fix workflow cleanup after expiry URL: https://github.com/apache/helix/pull/659 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes #658 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: In this commit three test that were unstable for some time has been stabilized. In this commit, a check has been added which only, allows the completed workflows to be cleaned up after expiry time. This will allow users to investigate the failed jobs. ### Tests - [x] The following is the result of the "mvn test" command on the appropriate module: [ERROR] Tests run: 889, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 3,537.078 s <<< FAILURE! - in TestSuite [ERROR] testForceDeleteJobFromJobQueue(org.apache.helix.integration.task.TestDeleteJobFromJobQueue) Time elapsed: 0.333 s <<< FAILURE! org.apache.helix.HelixException: Failed to delete job: testForceDeleteJobFromJobQueue_job2 from queue: testForceDeleteJobFromJobQueue at org.apache.helix.integration.task.TestDeleteJobFromJobQueue.testForceDeleteJobFromJobQueue(TestDeleteJobFromJobQueue.java:75) [INFO] [INFO] Results: [INFO] [ERROR] Failures: [ERROR] TestDeleteJobFromJobQueue.testForceDeleteJobFromJobQueue:75 ยป Helix Failed to ... [INFO] [ERROR] Tests run: 889, Failures: 1, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 59:02 min [INFO] Finished at: 2019-12-12T16:52:17-08:00 [INFO] ------------------------------------------------------------------------ This test is passed in individual testing. ### Commits - [x] The following tests are written for this issue: TestWorkflowExpiryTime - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
