narendly commented on issue #657: Patch zkClient leakage fix #656 URL: https://github.com/apache/helix/pull/657#issuecomment-565645410 > > Please fill out the following; > > The following tests are written for this issue: > > The following is the result of the "mvn test" command on the appropriate module: > > You could build the project at the top level directory using 'mvn clean install package -DskipTests' > > Then you could run tests in specific modules. For example, in helix-core/, you could run: 'mvn test'. > > Alternatively, if you want to save the logs into a file, you could also do: 'mvn test | tee file', which will save the output to a file named "file". > > @narendly We were discussing whether tests need to be written for my changes over this PR. If the tests are deemed unnecessary, I will run 'mvn test' over the current tests, post the results, and check both of the unchecked items. I think the changes in this PR are simple enough. I think existing tests will cover them. I'm fine with proceeding as is.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
