narendly commented on a change in pull request #639: Refine the WAGED
rebalancer to minimize the partial rebalance workload.
URL: https://github.com/apache/helix/pull/639#discussion_r359116262
##########
File path:
helix-core/src/main/java/org/apache/helix/controller/rebalancer/waged/model/ClusterModelProvider.java
##########
@@ -55,13 +129,14 @@
* @param baselineAssignment The persisted Baseline assignment.
Review comment:
So this could be confusing - as in for Global rebalance, we pass in an empty
map here but pass in baseline for bestPossibleAssignment. Do you think we
should change the variable names or just completely make 2 separate functions
instead of having a common `generateClusterModel`?
Or since this is a private method, we could add more descriptions around
this in the switch block. But this will confuse readers.
This is just a suggestion. Clearly, there is value in avoiding duplicate
code as seen here, but my concern is that parameter names could be misleading.
Maybe consider changing the parameter names so we're not passing in baseline
for best possible?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
