narendly opened a new pull request #666: Use ZnRecordSerializer in ConfigAccessor URL: https://github.com/apache/helix/pull/666 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: Fixes #665 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: ConfigAccessor is a Helix API used for CRUD access of Helix's data model such as ResourceConfig, InstanceConfig, etc.. These records are represented as ZNRecord and therefore needs to be serialized and deserialized with ZnRecordSerializer. This diff fixes ConfigAccessor so that it explicitly uses ZnRecordSerializer by default. ### Tests - [x] The following tests are written for this issue: TestConfigAccessor.java (enhanced with creating another ConfigAccessor object with the new constructor that takes in the ZK Address) - [ ] The following is the result of the "mvn test" command on the appropriate module: (Copy & paste the result of "mvn test") ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
