zhangmeng916 commented on a change in pull request #653: add Helix properties
factory and class
URL: https://github.com/apache/helix/pull/653#discussion_r362586939
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/ZKHelixManager.java
##########
@@ -245,6 +253,11 @@ public ZKHelixManager(String clusterName, String
instanceName, InstanceType inst
_stateListener = stateListener;
+ if (helixParticipantProperty != null) {
+ _helixParticipantProperty = helixParticipantProperty;
+ } else {
+ _helixParticipantProperty =
HelixPropertyFactory.getInstance().getHelixParticipantProperty(zkAddress,
clusterName);
+ }
Review comment:
I still think we should pass null if HelixParticipantProperty is not there.
Having an object but no value does not really benefit us.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
