kaisun2000 commented on a change in pull request #642: Fix handleNewSession
creating ephemeral node with expired session
URL: https://github.com/apache/helix/pull/642#discussion_r362965027
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
##########
@@ -1166,6 +1432,12 @@ private void acquireEventLock() {
}
try {
while (true) {
+ // Because ConnectionLossException and SessionExpiredException are
caught but not thrown,
Review comment:
@jiajunwang, let us document this invariant so that people who later change
the code knows what is the assumption here.
A lot of times later people who wrote the code would forget about the
invariant they assumed when they wrote the code.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
