alirezazamani opened a new pull request #675: Add REST API for Cluster Creation with CloudConfig URL: https://github.com/apache/helix/pull/675 ### Issues - [x] My PR addresses the following Helix issues and references them in the PR title: Fixes #674 ### Description - [x] Here are some details about my PR, including screenshots of any UI changes: This PR contains the relevant REST API calls for cluster creation. This change allows user to create cluster with CloudConfig. Multiple tests have been added in order to check the functionality of REST calls. ### Tests - [x] The following is the result of the "mvn test" command on the appropriate module: New tests have been added. TestCloudAccessor.testAddCloudConfigNonExistedCluster TestCloudAccessor.testAddCloudConfig TestCloudAccessor.testDeleteCloudConfig TestCloudAccessor.testUpdateCloudConfig TestClusterAccessor.testAddClusterWithCloudConfig TestClusterAccessor.testAddClusterWithInvalidCloudConfig TestClusterAccessor.testAddClusterWithInvalidCustomizedCloudConfig TestClusterAccessor.testAddClusterWithValidCustomizedCloudConfig TestClusterAccessor.testAddClusterWithCloudConfigDisabledCloud Test Result 1: helix-core: mvn test [INFO] Tests run: 904, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 3,444.069 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 904, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 57:29 min [INFO] Finished at: 2020-01-06T17:05:55-08:00 [INFO] ------------------------------------------------------------------------ Test Result 2: helix-rest: mvn test [INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 26.832 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 99, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ [INFO] Total time: 32.481 s [INFO] Finished at: 2020-01-07T09:25:20-08:00 [INFO] ------------------------------------------------------------------------ ### Commits - [x] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Code Quality - [x] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
