pkuwm commented on issue #642: Fix handleNewSession creating ephemeral node with expired session URL: https://github.com/apache/helix/pull/642#issuecomment-572300360 This PR is ready to be merged, approved by @kaisun2000 @jiajunwang Final commit message: ``` There is zk session race condition in zk helix manager. Zk session may expire and change during handling new session. If the expected session is expired when handling new session, the ephemeral node should NOT be created. Change list: - Change API create() in ZkClient to accept zk sessionId as a parameter. Add a new public API createEphemeral(final String path, final Object data, final String sessionId) to create an ephemeral node by the expected zk session. - Fire new session events and all events(child/data change events) to right after the first SyncConnected state is received in zk client. - Filter out stale sessions in handling new session. - Add multiple unit tests to cover the cases. ```
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
