jiajunwang opened a new pull request #679: Fix the Helix rest tests by cleaning up the environment before testing. URL: https://github.com/apache/helix/pull/679 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: #678 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: The validateWeight test methods in TestInstanceAccessor and TestPreInstanceAccessor are testing against the same instance config fields. There was a conflict if both of the test cases are executed in a certain order. This change adds cleanup logic so the shared fields will be empty before each test method starts. ### Tests - [ ] The following tests are written for this issue: Nothing new. Just fixing the tests. - [ ] The following is the result of the "mvn test" command on the appropriate module: [INFO] Tests run: 96, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 31.65 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 96, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation in the following wiki page: NA ### Code Quality - [ ] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
