pkuwm commented on a change in pull request #671: Add ZooKeeperAccessor to
helix-rest
URL: https://github.com/apache/helix/pull/671#discussion_r365972384
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/helix/PropertyStoreAccessor.java
##########
@@ -55,8 +56,8 @@
public Response getPropertyByPath(@PathParam("clusterId") String clusterId,
@PathParam("path") String path) {
path = "/" + path;
- if (!isPathValid(path)) {
- LOG.info("The propertyStore path {} is invalid for cluster {}", path,
clusterId);
+ if (!ZooKeeperAccessor.isPathValid(path)) {
+ LOG.error("The propertyStore path {} is invalid for cluster {}", path,
clusterId);
Review comment:
Nit, I don't think this error message is appropriate. I remembered @lei-xia
reviewed this in the previous ticket, this path invalidation is not an error in
the server. So keeping info (or warn) may be good enough.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
