jiajunwang commented on a change in pull request #653: add Helix properties 
factory and class
URL: https://github.com/apache/helix/pull/653#discussion_r366730747
 
 

 ##########
 File path: 
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java
 ##########
 @@ -76,9 +77,16 @@
   final StateMachineEngine _stateMachineEngine;
   final LiveInstanceInfoProvider _liveInstanceInfoProvider;
   final List<PreConnectCallback> _preConnectCallbacks;
+  final HelixParticipantProperty _helixParticipantProperty;
 
   public ParticipantManager(HelixManager manager, HelixZkClient zkclient, int 
sessionTimeout,
       LiveInstanceInfoProvider liveInstanceInfoProvider, 
List<PreConnectCallback> preConnectCallbacks) {
+    this(manager, zkclient, sessionTimeout, liveInstanceInfoProvider, 
preConnectCallbacks, null);
 
 Review comment:
   I agree with Hunter that it would be better to put an empty property if 
possible. Easier for us to handle the conditions. But it is optional, 
especially if you mark this constructor as deprecated.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org

Reply via email to