jiajunwang commented on a change in pull request #671: Add ZooKeeperAccessor to helix-rest URL: https://github.com/apache/helix/pull/671#discussion_r367599680
########## File path: helix-rest/src/main/java/org/apache/helix/rest/server/ServerContext.java ########## @@ -47,8 +47,8 @@ private ZKHelixAdmin _zkHelixAdmin; private ClusterSetup _clusterSetup; private ConfigAccessor _configAccessor; - // The lazy initialized base data accessor that reads/writes byte array to ZK - private ZkBaseDataAccessor<byte[]> _byteArrayBaseDataAccessor; + // A lazily-initialized base data accessor that reads/writes byte array to ZK Review comment: Since the comment here does not match what the accessor can do, can we at least comment or add a TODO here? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
