jiajunwang opened a new pull request #690: Reset the WAGED rebalancer once the controller newly acquires leadership. URL: https://github.com/apache/helix/pull/690 ### Issues - [ ] My PR addresses the following Helix issues and references them in the PR description: #660 ### Description - [ ] Here are some details about my PR, including screenshots of any UI changes: This is to prevent any cached assignment information which is recorded during the previous session from impacting the rebalance result. Detailed change list: 1. Move the stateful WAGED rebalancer to the GenericHelixController object instead of the rebalance stage. This is for resolving the possible race condition between the event processing thread and leader switch handling thread. 2. Add reset methods to all the stateful objects that are used in the WAGED rebalancer. 3. Refine some of the potential race condition in the WAGED rebalancer components. 4. Adjust the tests accordingly. Also adding new tests to cover the components reset / the WAGED rebalancer reset logic. ### Tests - [ ] The following tests are written for this issue: TestResourceChagneDetector.testResetSnapshot TestAssignmentMetadataStore.testAssignmentCache TestWagedRebalancer.testReset - [ ] The following is the result of the "mvn test" command on the appropriate module: [INFO] Tests run: 1064, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 4,162.076 s - in TestSuite [INFO] [INFO] Results: [INFO] [INFO] Tests run: 1064, Failures: 0, Errors: 0, Skipped: 0 [INFO] [INFO] ------------------------------------------------------------------------ [INFO] BUILD SUCCESS [INFO] ------------------------------------------------------------------------ ### Commits - [ ] My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 1. Subject is limited to 50 characters (not including Jira issue reference) 1. Subject does not end with a period 1. Subject uses the imperative mood ("add", not "adding") 1. Body wraps at 72 characters 1. Body explains "what" and "why", not "how" ### Documentation - [ ] In case of new functionality, my PR adds documentation in the following wiki page: (Link the GitHub wiki you added) ### Code Quality - [ ] My diff has been formatted using helix-style.xml
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
