zhangmeng916 commented on a change in pull request #653: add Helix properties
factory and class
URL: https://github.com/apache/helix/pull/653#discussion_r368339831
##########
File path:
helix-core/src/test/java/org/apache/helix/manager/zk/TestZkClusterManager.java
##########
@@ -54,27 +54,28 @@
@Test()
public void testController() throws Exception {
- System.out.println("START " + className + ".testController() at "
- + new Date(System.currentTimeMillis()));
+ System.out.println(
+ "START " + className + ".testController() at " + new
Date(System.currentTimeMillis()));
final String clusterName = CLUSTER_PREFIX + "_" + className +
"_controller";
// basic test
if (_gZkClient.exists("/" + clusterName)) {
_gZkClient.deleteRecursively("/" + clusterName);
}
- ZKHelixManager controller =
- new ZKHelixManager(clusterName, null, InstanceType.CONTROLLER,
ZK_ADDR);
-
try {
- controller.connect();
- Assert.fail("Should throw HelixException if initial cluster structure is
not setup");
+ ZKHelixManager controller =
Review comment:
I changed the logic so that backward compatibility can be maintained.
Basically, current logic allow constructing a ZKHelixManager without setting up
the cluster. So we have to allow a default cloud config setup before cluster is
set up. I think it is ok as we just set enabled to be false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
