jackjlli opened a new issue #692: Remove or downgrade the log level of message
"Invalid instance setup, missing znode path: {}"
URL: https://github.com/apache/helix/issues/692
Helix code explicitly prints the following line in error level, whereas it's
unnecessary to do so.
https://github.com/apache/helix/blob/2d9e8247a3197141ebe39813f3fe088a01e9b3e3/helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java#L149
The method `isInstanceSetup` gets called in multiple places. Most of them
will throw a Helix exception if the instance doesn't exist. Thus, there is no
need to log it again.
The other place that doesn't throw exception is from `ParticipantManager`,
where it tries to connect to the cluster as a participant. There's also no need
to log this message in error level in this case, which is misleading.
It'd be good to remove or downgrade this log message to info level, since
any exception can be thrown in exception class instead of this class, and it's
misleading to log this message in error level when connecting a participant to
cluster.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
