pkuwm commented on a change in pull request #688: Fix the watcher leakage issue
URL: https://github.com/apache/helix/pull/688#discussion_r368068484
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
##########
@@ -1261,31 +1258,62 @@ private void processDataOrChildChange(WatchedEvent
event, long notificationTime)
if (event.getType() == EventType.NodeDataChanged || event.getType() ==
EventType.NodeDeleted
|| event.getType() == EventType.NodeCreated) {
+ boolean isPathExist = event.getType() != EventType.NodeDeleted;
Set<IZkDataListenerEntry> listeners = _dataListener.get(path);
if (listeners != null && !listeners.isEmpty()) {
- fireDataChangedEvents(event.getPath(), listeners,
OptionalLong.of(notificationTime));
+ fireDataChangedEvents(event.getPath(), listeners, notificationTime,
isPathExist);
}
}
}
+ private void fireDataChangedEvents(final String path,
Set<IZkDataListenerEntry> listeners) {
Review comment:
I think you can refactor `fireDataChangedEvents(path, listeners,
notificationTime, isPathExist)` a bit, which `fireDataChangedEvents(path,
listeners)` can call. So we would avoid duplicate code and 2 branches of logic.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
