NealSun96 commented on issue #701: Create ShardingKeyTrieNode - a trie structure representing Zk path sharding keys URL: https://github.com/apache/helix/issues/701#issuecomment-579966732 Design pivot: based on the reviews gathered from the pull request #682 , there are concerns revolving the access to a trie node. Considering possible misuse, efforts were put in to ensure the integrity of a node, such as making the children unmodifiable and zkRealmAddress conditionally accessible; on top of that, opening up the trie node as a public interface also leads to potential repetition of trie traversal logic and exposure of unnecessary implementation details. Because of that, a new design is implemented, which encapsulates the trie node and instead allows user to interact with a trie class. The trie class offers a restrictive but sufficient set of operations that is expandable and is not prone to misuse. The trie class inherits from a generic interface, making it easy to substitute the trie solution with another brand new solution if we wish to do so in the future.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
