i3wangyi commented on a change in pull request #688: Fix the watcher leakage
issue
URL: https://github.com/apache/helix/pull/688#discussion_r375024068
##########
File path:
helix-core/src/main/java/org/apache/helix/manager/zk/zookeeper/ZkClient.java
##########
@@ -1309,22 +1306,24 @@ public void run() throws Exception {
}
}
- private void fireChildChangedEvents(final String path, Set<IZkChildListener>
childListeners) {
+ private void fireChildChangedEvents(final String path, Set<IZkChildListener>
childListeners, boolean pathExists) {
try {
- final ZkPathStatRecord pathStatRecord = new ZkPathStatRecord(path);
for (final IZkChildListener listener : childListeners) {
_eventThread.send(new ZkEvent("Children of " + path + " changed sent
to " + listener) {
@Override
public void run() throws Exception {
- // Reinstall watch before listener callbacks to check the znode
status
- if (!pathStatRecord.pathChecked()) {
Review comment:
@kaisun2000 Yes. However, as I replied earlier, this line
`pathStatRecord.recordPathStat(getStat(path, pathExists),
OptionalLong.empty());` does nothing (need to read the exact implemenation)
when `OptionalLong.empty()` is passed in. We're not recording propogation
latency for child listeners anyway. It only confuses us AND the `getStat()`
method will possibly add another leaked watch
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
