jiajunwang commented on a change in pull request #698: Implement Azure cloud
instance information processor
URL: https://github.com/apache/helix/pull/698#discussion_r376127133
##########
File path:
helix-core/src/main/java/org/apache/helix/cloud/azure/AzureCloudInstanceInformation.java
##########
@@ -42,7 +42,8 @@ public String get(String key) {
}
public static class Builder {
- private Map<String, String> _cloudInstanceInfoMap = null;
+
+ private final Map<String, String> _cloudInstanceInfoMap = new HashMap<>();
public AzureCloudInstanceInformation build() {
return new AzureCloudInstanceInformation(_cloudInstanceInfoMap);
Review comment:
Safer to clone construct a new map so the newly built instances do not share
anything.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
