jiajunwang commented on a change in pull request #718: Implement Helix nonblocking lock URL: https://github.com/apache/helix/pull/718#discussion_r377359284
########## File path: helix-lock/src/main/java/org/apache/helix/lock/ZKHelixNonblockingLockInfo.java ########## @@ -0,0 +1,92 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.helix.lock; + +import java.util.HashMap; +import java.util.Map; + +import org.apache.helix.ZNRecord; + + +public class ZKHelixNonblockingLockInfo<K extends ZKHelixNonblockingLockInfo.InfoKey, V extends String> implements LockInfo<K, V> { + + public static final String DEFAULT_OWNER_TEXT = ""; + public static final String DEFAULT_MESSAGE_TEXT = ""; + public static final long DEFAULT_TIMEOUT_LONG = -1L; + public static final String DEFAULT_TIMEOUT_TEXT = String.valueOf(DEFAULT_TIMEOUT_LONG); + private Map<InfoKey, String> lockInfo; + + public enum InfoKey { + OWNER, MESSAGE, TIMEOUT + } + + /** + * Constructor of ZKHelixNonblockingLockInfo that set each field to default data + */ + public ZKHelixNonblockingLockInfo() { Review comment: This could be confusing. I suggest having a static method for building unlocked lock. And you can keep an static final object internal, and we don't need to create new object every time. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org For additional commands, e-mail: reviews-h...@helix.apache.org
