narendly commented on a change in pull request #741: Fix ConcurrentModification
exception in Workflow Garbage Collection
URL: https://github.com/apache/helix/pull/741#discussion_r377954143
##########
File path: helix-core/src/main/java/org/apache/helix/task/TaskUtil.java
##########
@@ -1040,26 +1040,39 @@ public static void purgeExpiredJobs(String workflow,
WorkflowConfig workflowConf
/**
* The function that loops through the all existing workflow contexts and
removes IdealState and
* workflow context of the workflow whose workflow config does not exist.
+ * Try-catch has been used to avoid concurrent modification exception while
doing deep copy. Since
+ * Map.keySet() can produce concurrent modification exception.
Review comment:
1. move this to where try-catch is?
2. Explain why Map.keySet() throws CME w regards to copy constructor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
