NealSun96 commented on a change in pull request #759: Add validation logic to
MSD write operations
URL: https://github.com/apache/helix/pull/759#discussion_r379109153
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/TrieRoutingData.java
##########
@@ -89,49 +87,55 @@ public String getMetadataStoreRealm(String path)
+ DELIMITER + "\" character: " + path);
}
- TrieNode leafNode = findTrieNode(path, true);
- return leafNode.getRealmAddress();
+ TrieNode node = getLongestPrefixNodeAlongPath(path);
+ if (!node.isShardingKey()) {
+ throw new NoSuchElementException(
+ "No sharding key found within the provided path. Path: " + path);
+ }
+ return node.getRealmAddress();
+ }
+
+ public boolean isShardingKeyInsertionValid(String shardingKey) {
+ if (shardingKey.isEmpty() || !shardingKey.substring(0,
1).equals(DELIMITER)) {
+ throw new IllegalArgumentException(
+ "Provided shardingKey is empty or does not have a leading \"" +
DELIMITER
+ + "\" character: " + shardingKey);
+ }
+
+ TrieNode node = getLongestPrefixNodeAlongPath(shardingKey);
+ return !node.isShardingKey() && !node.getPath().equals(shardingKey);
}
/**
- * If findLeafAlongPath is false, then starting from the root node, find the
trie node that the
- * given path is pointing to and return it; raise NoSuchElementException if
the path does
- * not point to any node. If findLeafAlongPath is true, then starting from
the root node, find the
- * leaf node along the provided path; raise NoSuchElementException if the
path does not
- * point to any node or if there is no leaf node along the path.
+ * Given a path, find a trie node that represents the longest prefix of the
path. For example,
+ * given "/a/b/c", the method starts at "/", and attempts to reach "/a",
then attempts to reach
+ * "/a/b", then ends on "/a/b/c"; if any of the node doesn't exist, the
traversal terminates and
+ * the last existing node is returned.
+ * Note:
+ * 1. When the returned TrieNode is a sharding key, it is the only sharding
key along the
+ * provided path (the path points to this sharding key);
+ * 2. When the returned TrieNode is not a sharding key but it represents the
provided path, the
+ * provided path is a prefix(parent) to a sharding key;
+ * 3. When the returned TrieNode is not a sharding key and it does not
represent the provided
Review comment:
Yes it is. This scenario is when `path` is a sharding key that could be
added to the trie. Consider a trie that only has "/a/b/c" in it:
1. `getLongestPrefixNodeAlongPath("/a/b/c/x")` is the first case (typically
used during realm lookups), which returns "/a/b/c";
2. `getLongestPrefixNodeAlongPath("/a/b")` is the second case (typically
used during key scanning), which returns "/a/b";
3. `getLongestPrefixNodeAlongPath("/a/b/d")` is the last case, which returns
"/a/b". Note that "/a/b/d" is a valid sharding key to add.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
