narendly commented on a change in pull request #761: Add REST read endpoints to helix-rest for metadata store directory URL: https://github.com/apache/helix/pull/761#discussion_r379218026
########## File path: helix-rest/src/main/java/org/apache/helix/rest/metadatastore/constant/MetadataStoreRoutingConstants.java ########## @@ -28,14 +28,21 @@ // Leader election ZNode for ZkRoutingDataWriter public static final String LEADER_ELECTION_ZNODE = "/_ZK_ROUTING_DATA_WRITER_LEADER"; + // Field name in JSON REST response of getting all metadata store namespaces. + public static final String METADATA_STORE_NAMESPACES = "namespaces"; + // Field name in JSON REST response of getting metadata store realms in one namespace. public static final String METADATA_STORE_REALMS = "metadataStoreRealms"; // Field name in JSON REST response of getting sharding keys in one realm. - public static final String SINGLE_METADATA_STORE_REALM = "metadataStoreRealm"; + public static final String SINGLE_METADATA_STORE_REALM = "realm"; // Field name in JSON REST response of getting sharding keys. public static final String SHARDING_KEYS = "shardingKeys"; + // Field name in JSON REST response related to one single sharding key. + public static final String SINGLE_SHARDING_KEY = "shardingKey"; + // Field name in JSON REST response of getting sharding keys with prefix. + public static final String SHARDING_KEY_PREFIX = "prefix"; Review comment: `SHARDING_KEY_PREFIX`'s naming got me thinking for a little bit and I couldn't figure it out. Could we rename this? I think something like `SHARDING_KEY_PATH_PREFIX` would be more descriptive. To also help with understanding, could we please add where it's going to be used? (like getAllMappingUnderPath() for example). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
