narendly commented on a change in pull request #770: WIP: Add SharedZkClient
and update SharedZkClientFactory
URL: https://github.com/apache/helix/pull/770#discussion_r380935789
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/impl/factory/SharedZkClientFactory.java
##########
@@ -125,4 +132,74 @@ public int getActiveConnectionCount() {
}
return count;
}
+
+ public interface OnCloseCallback {
+ /**
+ * Triggered after the SharedZkClient is closed.
+ */
+ void onClose();
+ }
+
+ /**
+ * NOTE: do NOT use this class directly. Please use SharedZkClientFactory to
create an instance of SharedZkClient.
+ * InnerSharedZkClient is a ZkClient used by SharedZkClient to power ZK
operations against a single ZK realm.
+ */
+ public static class InnerSharedZkClient extends ZkClient implements
HelixZkClient {
Review comment:
@kaisun2000
InnerSharedZkClient is meant to preserve the behavior/logic of the original
SharedZkClient.
1. Clearly the code is not "exactly" the same. You have access to the
original SharedZkClient - please do a comparison.
2. What is the exact concern here? I'm not exactly sure what your question
is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
