dasahcc commented on a change in pull request #718: Implement Helix nonblocking
lock
URL: https://github.com/apache/helix/pull/718#discussion_r381031816
##########
File path: helix-lock/src/main/java/org/apache/helix/lock/HelixLock.java
##########
@@ -22,7 +22,7 @@
/**
* Generic interface for Helix distributed lock
*/
-public interface HelixLock<T> {
+public interface HelixLock {
Review comment:
Let's have the interface as DistributedLock or something. Name it HelixLock
still seemed to be sticking to Helix.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@helix.apache.org
For additional commands, e-mail: reviews-h...@helix.apache.org
