narendly commented on a change in pull request #799: [MSDS] Add REST endpoint
to get mapping of all sharding keys by realm
URL: https://github.com/apache/helix/pull/799#discussion_r382969417
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/metadatastore/MetadataStoreDirectory.java
##########
@@ -51,6 +52,14 @@
*/
Collection<String> getAllShardingKeys(String namespace);
+ /**
+ * Returns all path-based sharding keys by realm in the given namespace.
+ *
+ * @param namespace namespace in metadata store directory.
+ * @return Map: realm -> List of sharding keys
+ */
+ Map<String, List<String>> getShardingKeysByRealm(String namespace);
Review comment:
Great - thanks for providing your reasoning. I think this is minor, so if
you feel that making it a List will simplify things, we could leave it as is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
