dasahcc commented on a change in pull request #789: Add FederatedZkClient
URL: https://github.com/apache/helix/pull/789#discussion_r382294335
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/metadatastore/MetadataStoreDirectoryAccessor.java
##########
@@ -65,6 +66,11 @@ private void postConstruct() {
buildMetadataStoreDirectory(_namespace,
helixRestNamespace.getMetadataStoreAddress());
}
+ @PreDestroy
+ private void preDestroy() {
+ _metadataStoreDirectory.close();
Review comment:
Could the _metadataStoreDirectory to be null?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
