kaisun2000 edited a comment on issue #796: WIP: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#issuecomment-590637031 @narendly Test section updated with module. That is a good point. Current pattern of implementation of all public API of realmAwareZKClient is: 1/ Explicitly un-supported, would throw immediately without relying on delegation. 2/ Otherwise, if there is input zk path, always check it and then delegate to _innnerZKClient 3/ Otherwise, no zkPaht as input, delegate. This is easy to reason maintaining the original semantic. Also conforms with the original idea of using composition and delegation pattern.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
