dasahcc commented on a change in pull request #729: Implement Helix API for
updating customized state
URL: https://github.com/apache/helix/pull/729#discussion_r384149252
##########
File path: helix-core/src/main/java/org/apache/helix/manager/zk/ZKUtil.java
##########
@@ -139,6 +139,7 @@ public static boolean isInstanceSetup(HelixZkClient
zkclient, String clusterName
requiredPaths.add(PropertyPathBuilder.instanceConfig(clusterName,
instanceName));
requiredPaths.add(PropertyPathBuilder.instanceMessage(clusterName,
instanceName));
requiredPaths.add(PropertyPathBuilder.instanceCurrentState(clusterName,
instanceName));
+
requiredPaths.add(PropertyPathBuilder.instanceCustomizedState(clusterName,
instanceName));
Review comment:
Are we sure this is required path? That's not a good idea to add this. If we
add this and existing product uses Helix library for participant will have
check failure since Instance is already created.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
