narendly commented on a change in pull request #811: Fix zookeeper endpoint
error when path has leading slash
URL: https://github.com/apache/helix/pull/811#discussion_r384666372
##########
File path:
helix-rest/src/main/java/org/apache/helix/rest/server/resources/zookeeper/ZooKeeperAccessor.java
##########
@@ -62,14 +62,20 @@ public Response get(@PathParam("path") String path,
@QueryParam("command") Strin
if (cmd == null) {
return badRequest("Invalid ZooKeeper command: " + commandStr);
}
+ if (path == null) {
Review comment:
I don't think this PR is necessary because it is the caller's responsibility
to correctly format the URL. With the correct URL, it has already been verified
and tested that these endpoints work as expected.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
