narendly commented on issue #810: Zookeeper REST endpoint still prepends slash when path already has leading slash URL: https://github.com/apache/helix/issues/810#issuecomment-591562299 I don't think this PR is necessary because it is the caller's responsibility to correctly format the URL. With the correct URL, it has already been verified and tested that these endpoints work as expected. You're drawing a parallel to a REST resource concept, but clearly we aren't treating zookeeper paths as resource necessarily. Another way to do this is to treat the path variable as a query param, but to make the usage more fluid for users, we have decided to use regex. In short, I do not think there's an issue with the way it is implemented. One edge case though - can you see if you could getChildren on "/" (the root path) to work? That might be something that we could handle (if it doesn't work).
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
