narendly commented on issue #796: Add SharedZkClient/InnerSharedZkClient implementation URL: https://github.com/apache/helix/pull/796#issuecomment-591565836 @kaisun2000 1. Please review the following section and once you've understood and applied them, check the box in your PR description. > My commits all reference appropriate Apache Helix GitHub issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "How to write a good git commit message": > Subject is separated from body by a blank line > Subject is limited to 50 characters (not including Jira issue reference) > Subject does not end with a period > Subject uses the imperative mood ("add", not "adding") > Body wraps at 72 characters > Body explains "what" and "why", not "how" 2. Could you please update the test results on your latest commit? This is **very important** as we have seen failures after making extra commits. 3. Please review the following as well: **My diff has been formatted using helix-style.xml**
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
