narendly commented on a change in pull request #809: Add system property options to config auto compression URL: https://github.com/apache/helix/pull/809#discussion_r384680978
########## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/constant/ZkSystemPropertyKeys.java ########## @@ -0,0 +1,39 @@ +package org.apache.helix.zookeeper.constant; + +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +public class ZkSystemPropertyKeys { + /** + * Setting this property to true in system properties enables auto compression in ZK serializer. + * The data will be automatically compressed by + * {@link org.apache.helix.zookeeper.util.GZipCompressionUtil} when being written to Zookeeper + * if size of serialized data exceeds the configured threshold. + */ + public static final String ZK_SERIALIZER_AUTO_COMPRESSION_ENABLED = + "zk.serializer.auto-compression.enabled"; Review comment: It's actually the ZNRecord serializer, not zkSerializer, right? I don't think we support auto-compression in ZkSerializer? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
