zhangmeng916 commented on a change in pull request #814: Add basic
functionalities for RoutingTableProvider for CustomizedView
URL: https://github.com/apache/helix/pull/814#discussion_r384700098
##########
File path: helix-core/src/main/java/org/apache/helix/PropertyKey.java
##########
@@ -627,6 +630,33 @@ public PropertyKey externalView(String resourceName) {
return new PropertyKey(EXTERNALVIEW, ExternalView.class, _clusterName,
resourceName);
}
+ /**
+ * Get a property key associated with all {@link CustomizedView}
+ * @return {@link PropertyKey}
+ */
+ public PropertyKey customizedView() {
+ return new PropertyKey(CUSTOMIZEDVIEW, CustomizedView.class,
_clusterName);
+ }
+
+ /**
+ * Get a property key associated with an {@link CustomizedView} of a type
+ * @param type
+ * @return {@link PropertyKey}
+ */
+ public PropertyKey customizedView(String type) {
Review comment:
The parameter "type" is too generic. Let's make it more specific,
"stateType" or even "customizedStateType". Because the type is "String" instead
of a specific type, like "CustomizedStateType". We may have different kinds of
types, and by looking at "type", users do not know what it is referring to.
Some existing example is "propertyType", and users know exactly what the type
refers to.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
