lei-xia commented on a change in pull request #809: Add system property options
to config auto compression
URL: https://github.com/apache/helix/pull/809#discussion_r385373314
##########
File path:
zookeeper-api/src/main/java/org/apache/helix/zookeeper/datamodel/serializer/ZNRecordSerializer.java
##########
@@ -38,6 +39,17 @@
public class ZNRecordSerializer implements ZkSerializer {
private static Logger logger =
LoggerFactory.getLogger(ZNRecordSerializer.class);
+ // Reads from system property and represents whether auto compression is
enabled or not.
+ // If and only if this property is set to "true", auto compression is
enabled.
+ private final boolean autoCompressionEnabled =
+
Boolean.getBoolean(ZkSystemPropertyKeys.ZK_SERIALIZER_AUTO_COMPRESSION_ENABLED);
Review comment:
The default should be ENABLED if this is for Pinot, right?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
