kaisun2000 commented on issue #789: Add FederatedZkClient URL: https://github.com/apache/helix/pull/789#issuecomment-592239169 Overall, it looks ok. The important things are: 1/ Add a test case for close() 2/ I think the first checkCloseState() in getZkClient is not necessary, isn't it? 3/ Add comment about synchronize block and why? I see we don't do it for other places and in production we see problems due to later change by another developer who did not fully grasp what the original author's concurrency intention. Thus, let us document it and give people who make change this later a hint.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
