jiajunwang commented on a change in pull request #809: Add system property options to config auto compression URL: https://github.com/apache/helix/pull/809#discussion_r385974849
########## File path: zookeeper-api/src/main/java/org/apache/helix/zookeeper/datamodel/ZNRecord.java ########## @@ -49,6 +50,10 @@ @JsonIgnore(true) public static final String LIST_FIELD_BOUND = "listField.bound"; + /** A field name in ZNRecord's boolean fields to enable compression in ZNRecord serializers. */ + @JsonIgnore + public static final String ENABLE_COMPRESSION_BOOLEAN_FIELD = "enableCompression"; Review comment: Can we follow the convention that has an enum for the properties? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
